search

zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
13 stars 2 forks source link

Date published #1513

Closed giacomociti closed 4 months ago

giacomociti commented 4 months ago

should fix https://github.com/zazuko/cube-creator/issues/1502

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 3fb4e007f42f7ccb9ccf342a05cb2b3b1c222138

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------------------- | ----- | | @cube-creator/core-api | Patch | | @cube-creator/cli | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.06%. Comparing base (4a9a139) to head (3fb4e00).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1513 +/- ## ========================================== + Coverage 74.04% 74.06% +0.01% ========================================== Files 223 223 Lines 14994 15000 +6 Branches 838 837 -1 ========================================== + Hits 11103 11110 +7 + Misses 3882 3881 -1 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

giacomociti commented 4 months ago

I think it's important to add a test to the e2e run

do you mean API or UI e2e test?

tpluscode commented 4 months ago

I think it's important to add a test to the e2e run

do you mean API or UI e2e test?

Neither. I meant the publish pipeline run in cli/test/lib/commands/publish.test.ts