search

zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
13 stars 2 forks source link

build(deps): replace local `toCubeShape` with `barnard59-cube` #1515

Closed tpluscode closed 4 months ago

tpluscode commented 4 months ago
changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 94c34c25489bc77b039067a1e1710c4647c12a6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @cube-creator/cli | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.58%. Comparing base (8dcb7ec) to head (94c34c2).

Files Patch % Lines
cli/lib/cube.ts 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## b59-up #1515 +/- ## ========================================== + Coverage 71.04% 73.58% +2.53% ========================================== Files 223 219 -4 Lines 15009 14729 -280 Branches 806 839 +33 ========================================== + Hits 10663 10838 +175 + Misses 4337 3882 -455 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tpluscode commented 4 months ago

@giacomociti I removed one last failing test for the case of min/max + IRI dimension. Thought it did not make sense to replicate that test from b59 as it ws getting a little awkward