zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
13 stars 2 forks source link

Fix publish job using newest barnard59 #1518

Closed tpluscode closed 4 months ago

tpluscode commented 4 months ago

I found that the publish job had issues when it tried to update the status in case of cube validation failure. Turned out that the cause was invalid SPARQL where the cube-link validation shapes were serialized as invalid prefixed names like cube:shape/standalone-constraint-constraint#PropertyWithName, lacking the escaping of slash and hash.

While I was on it, I simplified the loadCube.ts. Can't remember anymore why there was that PassThrough. It appears redundant now

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 7dec0568e9cf21cf33b664b15db2970066eca78c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.57%. Comparing base (a7c3681) to head (7dec056).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1518 +/- ## ========================================== - Coverage 73.59% 73.57% -0.02% ========================================== Files 219 219 Lines 14726 14712 -14 Branches 839 838 -1 ========================================== - Hits 10837 10825 -12 + Misses 3880 3878 -2 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.