Closed tpluscode closed 4 months ago
Latest commit: 7dec0568e9cf21cf33b664b15db2970066eca78c
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.57%. Comparing base (
a7c3681
) to head (7dec056
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I found that the publish job had issues when it tried to update the status in case of cube validation failure. Turned out that the cause was invalid SPARQL where the cube-link validation shapes were serialized as invalid prefixed names like
cube:shape/standalone-constraint-constraint#PropertyWithName
, lacking the escaping of slash and hash.While I was on it, I simplified the
loadCube.ts
. Can't remember anymore why there was thatPassThrough
. It appears redundant now