search

zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
13 stars 2 forks source link

fix: transform invalid dates #1523

Closed tpluscode closed 3 months ago

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 24c38a7a76f6cebe1028ab1683b3fe903347352f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | @cube-creator/core-api | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.51%. Comparing base (cfdb26d) to head (24c38a7). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1523 +/- ## ========================================== + Coverage 73.50% 73.51% +0.01% ========================================== Files 219 219 Lines 14880 14889 +9 Branches 849 855 +6 ========================================== + Hits 10937 10946 +9 Misses 3934 3934 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

giacomociti commented 3 months ago

with the latest version of the csvw parser, invalid date values (like 'foo'or '500000') are correctly reported. Still, a value like '2000' is silently parsed successfully and transformed to '2000-01-01'^^xsd:date. Since '2000' would be invalid as an xsd:date but allowed by ISO 8601 I guess this is the desired behavior @tpluscode

tpluscode commented 3 months ago

I guess this is the desired behavior

Have you compared with the previous version?