search

zazuko / cube-link

Cube Schema
https://zazuko.github.io/cube-link/
Other
11 stars 8 forks source link

deduplicate minCount|maxCount Violations #186

Closed Rdataflow closed 2 months ago

Rdataflow commented 2 months ago

The current implementation catches Violations twice (once only will do 😄 )

Violation: "sh:maxCount needs to be 1" at focus node _:b89_b89_b90_anon2dgenid2d6499f875b0c2499c8204f64b9ba131932d3 with path <http://www.w3.org/ns/shacl#maxCount> (HasValueConstraintComponent of source: _:b89_b781)
Violation: "sh:maxCount needs to be 1" at focus node _:b89_b89_b90_anon2dgenid2d6499f875b0c2499c8204f64b9ba131932d3 with path <http://www.w3.org/ns/shacl#maxCount> (MinCountConstraintComponent of source: _:b89_b781)
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 3a487fce7527ebaec7681ca3640b86bf52872999

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Rdataflow commented 2 months ago

@giacomociti thank you for catching this :+1: