fix: do not crash when dimension property has no sh:path

zazuko / rdf-cube-view-query

RDF Cube View Schema query library

2 stars 3 forks source link

fix: do not crash when dimension property has no sh:path #50

Closed martinmaillard closed 3 years ago

martinmaillard commented 3 years ago

If a property of the metadata shape had no sh:path (or multiple of them), Cube.dimensions would crash. This PR just ignores malformed dimension properties.

bergos commented 3 years ago

@martinmaillard I guess it was related to a bug in @rdfjs/term-set. Can you check if it's working now without changes in the rdf-cube-view-query library? I released a new version of term-set that includes this fix: https://github.com/rdfjs-base/term-set/commit/5c0c38283537a85a57cd10b52315b4a37a1f8062

martinmaillard commented 3 years ago

Yup, it seems to work