fix: filter column is not result column

[tpluscode]

The Dimensions class iterates all columns and marks them with isResult and isFilter

I think the two flags are mutually exclusive but a filter column would have been marked as "result" causing issues downstream when we try to generate CSV from a view

[tpluscode]

It cannot look ok if there are tests failing :D

[tpluscode]

There, I had to change that logic to take view:projection into account. If present, only those columns are marked as isResult because only those will be part of the SELECT clause

[cristianvasquez]

What is the modern way to review pull requests with an instantiated editor?

[tpluscode]

What is the modern way to review pull requests with an instantiated editor?

I don't understand the question

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 70098f7c6ccb40483ddcfd6b5bf20051e13f2c6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------------- | ----- | | rdf-cube-view-query | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[cristianvasquez]

Needs standard fix

[cristianvasquez]

What is the modern way to review pull requests with an instantiated editor?

I don't understand the question

Wondering how one can review branches without having to setup all the environments, and run/modify tests there.

[tpluscode]

Wondering how one can review branches without having to setup all the environments, and run/modify tests there.

Gitpod, potentially