search

zazuko / rdf-validate-shacl

Validate RDF data purely in JavaScript. An implementation of the W3C SHACL specification on top of the RDFJS stack.
MIT License
95 stars 12 forks source link

fix #125 #126

Closed giacomociti closed 2 months ago

giacomociti commented 3 months ago

still a draft, looking for early feedback and advice on additional testing

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 3f77cc9edc8497450add691d358b78e5a2b7d814

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------ | ----- | | rdf-validate-shacl | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

giacomociti commented 3 months ago

For testing, check the directory test/data/data-shapes/custom. I would place additional test cases there.

I'm afraid we cannot rely on the machinery for official tests: the spec is agnostic wrt sh:detail. According to the test suite documentation:

Before comparing the results graph with the expected results, the actual validation report must not include any "nested" results, via sh:details.

and in fact details are removed before comparing the actual with the expected results