zazuko / trifid

Lightweight Linked Data Server and Proxy
Apache License 2.0
77 stars 10 forks source link

Remove `chai-as-promised` #350

Closed ludovicm67 closed 3 months ago

ludovicm67 commented 3 months ago

chai-as-promised was not updated for 7 years.

Removing it allows us to upgrade chai to v5.

chai-as-promised was only used to test is a promise was resolving or rejecting ; I added two functions that takes care of those checks instead.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: cd9db03494c921656790eedfc02fdb5a89ce1dab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.00%. Comparing base (7e26710) to head (cd9db03).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #350 +/- ## ======================================= Coverage 41.00% 41.00% ======================================= Files 47 47 Lines 3131 3131 ======================================= Hits 1284 1284 Misses 1847 1847 ``` | [Flag](https://app.codecov.io/gh/zazuko/trifid/pull/350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | Coverage Δ | | |---|---|---| | [ckan](https://app.codecov.io/gh/zazuko/trifid/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `97.75% <ø> (ø)` | | | [core](https://app.codecov.io/gh/zazuko/trifid/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `21.23% <ø> (ø)` | | | [entity-renderer](https://app.codecov.io/gh/zazuko/trifid/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `54.92% <ø> (ø)` | | | [graph-explorer](https://app.codecov.io/gh/zazuko/trifid/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `0.00% <ø> (ø)` | | | [handler-fetch](https://app.codecov.io/gh/zazuko/trifid/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `49.49% <ø> (ø)` | | | [iiif](https://app.codecov.io/gh/zazuko/trifid/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `44.05% <ø> (ø)` | | | [markdown-content](https://app.codecov.io/gh/zazuko/trifid/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `95.65% <ø> (ø)` | | | [yasgui](https://app.codecov.io/gh/zazuko/trifid/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `0.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.