search

zazuko / xrm

A friendly language for mappings to RDF
MIT License
1 stars 0 forks source link

Validation rules for LogicalSource #22

Closed mchlrch closed 5 years ago

mchlrch commented 5 years ago

https://github.com/zazuko/rdf-mapping-dsl/issues/3

I cherrypicked from netage branch and added missing validation for the case, when LogicalSource is top-level (without enclosing SourceGroup)

I would like to have unit-tests for the validation in place, before merging back to master. @nicky508 Could you have a look at "Testing Validators" in https://www.eclipse.org/Xtext/documentation/303_runtime_concepts.html#testing and adding the respective tests to this PR?

nicky508 commented 5 years ago

@mchlrch Great, I think I missed that case, since I was completely in the source group/logical source combinations. Yes I take a look and will create validation tests for the situations.

mchlrch commented 5 years ago

The Maven build didn't run the tests with the filename ending in Tests, so I renamed it to Test. Some tests failed first. I got them all green by removing the numerical offset and length parameters from the assertions.

nicky508 commented 5 years ago

The Maven build didn't run the tests with the filename ending in Tests, so I renamed it to Test. Some tests failed first. I got them all green by removing the numerical offset and length parameters from the assertions.

Without the offset and length I run into failures.

nicky508 commented 5 years ago

The Maven build didn't run the tests with the filename ending in Tests, so I renamed it to Test. Some tests failed first. I got them all green by removing the numerical offset and length parameters from the assertions.

Without the offset and length I run into failures.

Never mind, not everything was in sync.