search

zazuko / xrm

A friendly language for mappings to RDF
MIT License
1 stars 0 forks source link

Proposals don't properly respect prefix ending with delimiter #44

Closed mchlrch closed 4 years ago

mchlrch commented 4 years ago

Proposals for prefix ex. also contain candidates beginning with exPLZ.

image

I had already fixed that in the initial prototype, but apparently forgot to copy the respective code when I recreated the repository in the zazuko organisation.

https://github.com/mchlrch/experimental-rmdsl/tree/master/com.zazuko.experimental.rmdsl.parent/com.zazuko.experimental.rmdsl.ui

./src/com/zazuko/experimental/rmdsl/ui/RdfMappingUiModule.xtend
./src/com/zazuko/experimental/rmdsl/ui/contentassist/RdfMappingPrefixMatcher.xtend

Interaction with #12

nnamtug commented 4 years ago

given example of RdfMappingPrefixMatcher clashes with having different qualified name separartors introduced by #12 . proposing simple substring matching: any substring of a segment would match:

wgs84_pos:long 
// would be matched by
wgs
long
long
l
84
...
mchlrch commented 4 years ago

any substring of a segment would match

fine with me

nnamtug commented 4 years ago

included in #12 respectively pullrequest #58

mchlrch commented 4 years ago

Works now as expected, closing this