search

zazuko / xrm

A friendly language for mappings to RDF
MIT License
1 stars 0 forks source link

LogicalSource.iterator unused? #74

Open nnamtug opened 4 years ago

nnamtug commented 4 years ago

https://github.com/zazuko/rdf-mapping-dsl/blob/bda63d6d3eb6e42164ad09f69b00973311679a9f/com.zazuko.rdfmapping.dsl.parent/com.zazuko.rdfmapping.dsl/src/com/zazuko/rdfmapping/dsl/RdfMapping.xtext#L43

LogicalSource.iterator seems to be unused.

@mchlrch : Feature or bug?

mchlrch commented 4 years ago

iterator is only used for RML and CARML output

https://github.com/zazuko/rdf-mapping-dsl/blob/master/com.zazuko.rdfmapping.dsl.parent/com.zazuko.rdfmapping.dsl/src/com/zazuko/rdfmapping/dsl/generator/rml/RmlDialect.xtend#L23

If iterator is used in csv sources, it has no effect. And currently there is no validation or customized proposals implemented yet, it seems. I will create new issues for that, please leave this one open as a reminder.