zazukoians / trifid-ld

This repository is DEPRECATED please goto:
https://github.com/zazuko/trifid
Apache License 2.0
18 stars 9 forks source link

Rename config.fuseki.json to config.sparql.json #52

Closed ktk closed 7 years ago

ktk commented 7 years ago

So it looks more generic

l00mi commented 7 years ago

Hm, that makes no sense? This was introduced because you wanted to have multiple configs for different stores.. there will be a config.stardog.json and config.virtuos.json later on.

ktk commented 7 years ago

I don't think that makes sense for most stuff in the options. The stuff which is different for SPARQL endpoints is quite small, mostly about the DESCRIBE statement and possible auth. Duplicating the whole config for that looks like overkill to me.

l00mi commented 7 years ago

What was exactly we argued in the meeting in Biel. So I hope @bergos will not be angry of reverting.

bergos commented 7 years ago

Fixed in the dev branch with this commit. If we need a Fuseki config, we can use the new "baseConfig" feature and just replace values of the query values.