search

zb3 / freej2me

A free cross-platform desktop J2ME emulator with 3D support from J2ME-Loader
Other
13 stars 2 forks source link

Libretro/RetroArch support #6

Open kuba2k2 opened 3 weeks ago

kuba2k2 commented 3 weeks ago

Hi, I see that Libretro support has been removed in this fork. Do you plan for bringing it back at some point? If not, what is the reason for that?

zb3 commented 3 weeks ago

I had no other choice, because I'd not have the energy and will to update and maintain these code paths and I didn't even know how these worked. I removed that so I could modify the FreeJ2ME class, that was a sacrifice I had to make in order to be able to finish this fork.

Currently I'm unable to update this further, ideally someone from the original FreeJ2ME project could help here, but I've done my part..

kuba2k2 commented 3 weeks ago

I understand. Would you accept PRs to your repository if there are any, and/or have you considered submitting your work as a PR to the upstream repo? I will be building something based on Libretro at some point, maybe I'll be able to bring back the support in freej2me.

zb3 commented 3 weeks ago

Would you accept PRs to your repository if there are any

If they're small enough that I can understand them :)

have you considered submitting your work as a PR to the upstream repo?

Initially I planned to contribute to the original repo by fixing bugs. Unfortunately, even the most basic PR that fixed searching for main class is still not merged, I guess they no longer have time to maintain the project.. That's why I forked the project and went "all in" to add stuff like M3G :)

I will be building something based on Libretro at some point, maybe I'll be able to bring back the support in freej2me.

Sounds interesting. I see that in the original integration, things were duplicated between the FreeJ2ME class and the Libretro class.. it'd be much easier to maintain if the same core worked for AWT and Libretro, and platform-specific code was only responsible for platform-specific things..

Anyway, wish you luck :)