search

zbateson / mail-mime-parser

An email parser written in PHP
https://mail-mime-parser.org/
BSD 2-Clause "Simplified" License
458 stars 58 forks source link

Add support for PHP 8.1 #181

Closed Nielsvanpach closed 2 years ago

Nielsvanpach commented 2 years ago

Opened in draft as a test is failing. I haven't figured out what changed in 8.1 for this to happen. I know html encoding and decoding functions handle single quotes differently in 8.1, but I don't think they are used anywhere?

Fyi, it's the first ' in '这也不会,那也不会' that is different.

While searching for a solution on this, I quickly tried to migrate zbateson/mb-wrapper to Github Actions, but for some reason that's not working as suspected. Feel free to fix or just close that PR: https://github.com/zbateson/mb-wrapper/pull/5

zbateson commented 2 years ago

Hi @Nielsvanpach --

Thanks for this. It seems there was NUL char at the beginning of the string for some reason, and for some reason php before 8.1 would just ignore that.

Thanks for this :)