Fix PHP 8.1 return type deprecation notices

zbateson / mail-mime-parser

An email parser written in PHP

https://mail-mime-parser.org/

BSD 2-Clause "Simplified" License

441 stars 56 forks source link

Fix PHP 8.1 return type deprecation notices #198

Closed joelharkes closed 1 year ago

joelharkes commented 1 year ago

Still missing in HeaderStream.

Got following message in our unit testing code:

PHP Deprecated:  Return type of ZBateson\MailMimeParser\Stream\HeaderStream::update(SplSubject $subject) should either be compatible with SplObserver::update(SplSubject $subject): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/mobilityshop-api/mobilityshop-api/vendor/zbateson/mail-mime-parser/src/Stream/HeaderStream.php on line 51

zbateson commented 1 year ago

Thanks @joelharkes

joelharkes commented 1 year ago

thanks for the merge! :)