Closed phpfui closed 1 year ago
Unit test failures are all due to dropping older versions of PHP. OK to merge.
Should be good now, I thought I removed old PHP versions, but apparently on another branch I trashed.
This is amazing work, thank you very much!
Lots of changes. I put most in the final commit so you can see everything in one commit. This is a major improvement to the package and will make maintenance easier going forward.
I tried to add scalar parameter types and return types where ever possible. I did not type the object returns, as I am not that familiar with how the code should work and you may want to use a more abstract or concrete class depending on the situation. Also this can cause problems with type mismatches at run time, so you have to be careful.
I also did not change any logic where ever possible. This should be just specifying parameter and return types.
I did not resolve all PHPStan errors, as you should take a look, but I got most of them. I think the remaining issues are more judgement calls for you.
Things that should be considered going forward:
Let me know what else needs to be done / changed.