search

zbateson / mail-mime-parser

An email parser written in PHP
https://mail-mime-parser.org/
BSD 2-Clause "Simplified" License
458 stars 58 forks source link

Update type hint #235

Closed nepster-web closed 6 months ago

nepster-web commented 6 months ago

Hello,

Times change PHP evolves, and when updating very often similar problems arise:

image

I noticed that you forgot to replace #[\ReturnTypeWillChange] with type hint.

https://github.com/zbateson/mail-mime-parser/blob/2.4.0/src/Container.php#L98 https://github.com/zbateson/mail-mime-parser/blob/2.4.0/src/Message/PartChildrenContainer.php#L132

it seems this should work in 2021