zbenjamin / vec_noise

Vectorized perlin noise library for Python
Other
4 stars 2 forks source link

setup.py uses __NUMPY_SETUP__, which has been removed since NumPy 1.11.2 #5

Open AC-Mnky opened 1 year ago

AC-Mnky commented 1 year ago

signals the error AttributeError: 'dict' object has no attribute '__NUMPY_SETUP__'

Xmaster6y commented 2 months ago

I have a fix. @zbenjamin are you accepting PRs?

Xmaster6y commented 2 months ago

My fix temporarily lives at https://github.com/Xmaster6y/vec_noise/tree/refacto.

zbenjamin commented 2 months ago

I'd accept a PR that narrowly fixes the issue. However, your fixes include several other unnecessary changes. Could you cut your fix down to the minimal necessary change?

May you know the path of peace, Zev

On Mon, Sep 16, 2024 at 7:58 AM, Yoann Poupart < @.*** > wrote:

My fix temporarily lives at https:/ / github. com/ Xmaster6y/ vec_noise/ tree/ refacto ( https://github.com/Xmaster6y/vec_noise/tree/refacto ).

— Reply to this email directly, view it on GitHub ( https://github.com/zbenjamin/vec_noise/issues/5#issuecomment-2353169160 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAAOKPEPKX4L44BCHAZDQ7TZW3W2DAVCNFSM6AAAAABOJLG3MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTGE3DSMJWGA ). You are receiving this because you were mentioned. Message ID: <zbenjamin/vec_noise/issues/5/2353169160 @ github. com>