zbirenbaum / copilot.lua

Fully featured & enhanced replacement for copilot.vim complete with API for interacting with Github Copilot
MIT License
2.45k stars 67 forks source link

the content/font of the suggestion is always shaking #130

Closed uxfion closed 1 year ago

uxfion commented 1 year ago

When I do the typing, the content/font of the Suggestion prompt is always jittering.

I'm not quite sure if this jittering is inherently present or caused by a bug.

The video below is using copilot.lua and the font has a noticeable jitter

https://user-images.githubusercontent.com/44778029/220706299-52bcc396-cbd8-4aab-8e40-86632f17f4e4.mov

And the video below is using copilot.vim, the font doesn't shake either when deleting or typing

https://user-images.githubusercontent.com/44778029/220706438-978cd1f5-2c2e-4670-b49b-b1a087959fe1.mov

I have no clue to solve this problem. Please let me know if there is any progress on this

MunifTanjim commented 1 year ago

@uxfion can you check https://github.com/zbirenbaum/copilot.lua/pull/131?

uxfion commented 1 year ago

@uxfion can you check #131?

I used the new branch fix-suggestion-flicker

image

and it showed an error at line 190 of sugestion.lua

MunifTanjim commented 1 year ago

Pushed a fix... how about now? 🤔

uxfion commented 1 year ago

https://github.com/zbirenbaum/copilot.lua/pull/131#issuecomment-1441963620