search

zbirenbaum / copilot.lua

Fully featured & enhanced replacement for copilot.vim complete with API for interacting with Github Copilot
MIT License
2.63k stars 75 forks source link

Make extmark options configurable #191

Closed MariaSolOs closed 1 year ago

MariaSolOs commented 1 year ago

I use indent-blankline for having indentation guides. However, because this plugin uses hl_mode = 'combine', the guides aren't visible in the suggestion, which generates a weird UI experience.

image

To fix this I suggest making these options configurable :)

lukas-reineke commented 1 year ago

This happens because the suggested code is not actual text in the buffer yet. It is virtual text on virtual lines. So indent-blankline doesn't know about it, and can't make indent guides for it.

The only really solution I see for this would be that indent-blankline exposes an API that copilot could run to augment generated text with indent guides. But this doesn't currently exist, and would be quite a bit of work to implement.

MunifTanjim commented 1 year ago

@MariaSolOs, as @lukas-reineke mentioned... even if we make extmark configurable it won't solve the issue right now.

MariaSolOs commented 1 year ago

@lukas-reineke thank you for explaining! That’s fair, it is definitely a nice to have but if the feature isn’t worth the effort then it is okay :)

I’ll close this then @MunifTanjim.