zbjdonald / synology-drive-api

Synology drive api python wrapper.
MIT License
64 stars 16 forks source link

dsm_version parameter not working #5

Closed schulz closed 2 years ago

schulz commented 2 years ago

Hi,

dsm_version parameter is not accepted by SynologyDrive class and is not passed to SynologySession. SynologySession dsm_version default value is 6 thus the documentation description is wrong, please update the code.

zbjdonald commented 2 years ago

I'll check it tomorrow.

wellsleep commented 2 years ago

same problem encountered.

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_106/412349273.py in <module>
----> 1 with SynologyDrive(NAS_USER, NAS_PASS, NAS_IP, dsm_version='7') as synd:
      2     pass

TypeError: __init__() got an unexpected keyword argument 'dsm_version'
zbjdonald commented 2 years ago

@wellsleep I'll fix it on Monday.

zbjdonald commented 2 years ago

@schulz @wellsleep You can try 1.0.6.

wellsleep commented 2 years ago

1.0.6 worked!

schulz commented 2 years ago

@zbjdonald it works, thank you!