zbluebugz / facebook-clean-my-feeds

Clean up Facebook feeds by hiding sponsored, suggestions and other posts based on keywords.
GNU General Public License v3.0
113 stars 13 forks source link

Feature request or Bug? #33

Closed Weaver1911 closed 1 year ago

Weaver1911 commented 1 year ago

Hello. I have this strange behavior with this script. I'm using it -probably- more than a year flawlessly. But for few weeks now it doesn't work as it should be. It's worth mentioning that i use Greek language. So here how i made it work all these months.

At first i had to replace 'en': 'Sponsored', with 'en': 'Χορηγούμενη', and 'en': 'Suggestions / Recommendations', with 'en': 'Προτείνεται για εσάς',

After few months it stopped working again, so i reverted everything in the original format. "en", and it was working just fine.

Now. nothing is working and it gives me that strange behavior Screenshot 2023-06-14 141500

As you can see it works (partially) because it's hiding all bs at first, but while you scrolling down, it does absolutely nothing. Although Sponsored post are hidden, but i don't get that label. Probably adblock (uBlock Origin) works for Facebook too.

Can you please officially add Greek language to the script to test it out?

Specs

Browser: Microsoft Edge
Injector: Tampermonkey BETA
OS: Win 10 and Win 11

Thanks in advance.

zbluebugz commented 1 year ago

Thanks for the feedback and info.

I have switched one of my FB accounts to Greek and can see the issue.

FB is serving an older HTML structure to Greek users - which is kind of unexpected.

FYI, the script doesn't use keywords to detect Sponsored posts - it looks for certain a HTML pattern that is unique to Sponsored posts.

I will update the script to work with the HTML structure served to Greek users.

Will look into adding Greek to the script's dictionary of keywords (used for displaying CMF's dialog and labels in user's languages).

FYI, uBO does hide FB sponsored posts for Greek users (this is the reason you're not seeing any CMF labels if CMF is failing to detect them).

Weaver1911 commented 1 year ago

Thank you for your fast reply.

FYI, the script doesn't use keywords to detect Sponsored posts - it looks for certain a HTML pattern that is unique to Sponsored posts.

Yes you are right. I just checked your code. Maybe I've changed something else too. It's huge script and I can't remember, because instead of a full install I was only updating parts of your code in each update released.

Will look into adding Greek to the script's dictionary...

If this is only for the UI Localization, it is not necessary. Most Greeks (around 80%) know English. If you don't mind, you can do it. It's up to you

uBO does hide FB sponsored posts for Greek users

I figure 😅



I think that's all from me. Thank you so much for your time and effort.



P.S

I have switched one of my FB accounts to Greek

Holy f... You just triggered a flashback. That's the problem. My FB was in English before. After i formatted my PC (with Greek language -my mistake-) FB recognize my machine regional settings and now it's in Greek. I'm an idiot. But. we've found a bug. that's something.

zbluebugz commented 1 year ago

Version 4.21 has been released.

Weaver1911 commented 1 year ago

Seems to be working fine again now. Thank you.

FYI. This is why we need it. I don't know if it's FB bug or whatever. But this is the only solution if you want to watch your feed. fb And yes. All of these was between 2 posts. No joke.

zbluebugz commented 1 year ago

That looks like my Groups feed too - I often get 100+ suggestions in a row ... It's FB's AI feeling somewhat overly helpful! :-)

You can group/aggregate those notification tabs in the Groups Feed and Videos Feed. Open up CMF's Options and scroll down to "Verbosity", then choose "7 posts hidden" - this will group all those consecutive notification tabs into one.

For News Feed, no grouping of the notification tabs is applied due to FB showing max of 5 posts at a time and removing the earlier ones. Instead the code will show single notification tabs.

Weaver1911 commented 1 year ago

Yeah i noticed that. Sure yes. i know how to do that. I've just put it that way to see what's going on. i have everything "Hidden". But out of curiosity i've checked the grouping, and doesnt seems to work. For example:

fb3

All of them are "Recommended" i checked it twice. the 5th is "Sponsored" So if i remember correctly the script should've had only two tabs. one with "4 posts hidden, Rule: ..... " and the "Sponsored" as is. But i doesn't (as you can see). Can you confirm? If this is happening only on my end, it's ok. I don't really care. Like i said, i have "no message" selected. But maybe some users need that, and it's good those functions exist.

zbluebugz commented 1 year ago

Grouping of Notification Tabs only work in Groups and Videos feeds.

The Grouping option groups them regardless the type of rule that was triggered. So, Sponsored posts would be grouped with Suggested Posts, etc.

However, when the grouping appears to be "broken" into 2 lots, it is usually triggered by a "fake"/"dummy" post with no content (dunno why FB does this) and the script considers them to be "clean" posts. The consecutive counter is reset everytime the code encounters a "clean" post.

I did a quick test in Edge (108) and Tampermonkey Beta and it is grouping them for me. Not too sure why it isn't doing it for you. However, you seem to be happy enough using the option to disable the Notifcation Tabs, which in turn "hides" this weird bug :-)

Thanks for your feedback - muchly appreciated.