search

zblz / naima

Derivation of non-thermal particle distributions through MCMC spectral fitting
http://naima.readthedocs.io
BSD 3-Clause "New" or "Revised" License
45 stars 54 forks source link

Astropy Affiliated Package Review #162

Closed astrofrog closed 7 years ago

astrofrog commented 7 years ago

This package has been re-reviewed by the Astropy coordination committee in relation to the Astropy affiliated package ecosystem.

We have adopted a review process for affiliated package that includes assigning quantitative ‘scores’ (red/orange/green) for different categories of review. You can read up more about this process here. (This document, currently in Google Docs, will be moved to the documentation in the near future.) For each of the categories below we have listed the score and have included some comments when the score is not green.

Functionality/ScopeSpecialized%20package
No further comments
Integration with Astropy ecosystemGood
At this time it seems that naima does not integrate with astropy.modeling. At the time of the last review this was because astropy.modeling did not support units on parameters, but now this is in astropy core, so it would be good to see if this can now be done (but this is recent so we are leaving this green for now).
DocumentationGood
No further comments
TestingGood
No further comments
Development statusGood
No further comments
Python 3 compatibilityGood
No further comments

Summary/Decision: Everything looks great, keep up the good work! :trophy:'

If you agree with the above review, please feel free to close this issue. If you have any follow-up questions or disagree with any of the comments above, leave a comment and we can discuss it here. At any point in future you can request a re-review of the package if you believe any of the scores should be updated - contact the coordination committee, and we’ll do a new review. Note that we are in the process of redesigning the http://affiliated.astropy.org page to show these scores (but not the comments). Finally, please keep the title of this issue as-is (“Astropy Affiliated Package Review”) to make it easy to search for affiliated package reviews in future.

zblz commented 7 years ago

Thanks for the continued review, sounds like a great idea! The comment with regards to astropy.modeling integration is tracked in issue #90, so I'll close this issue.