search

zbraniecki / l20n

Python l20n support library
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Ignore l10n-path if the node has already been translated once #8

Closed stasm closed 12 years ago

stasm commented 12 years ago

This should fix the bug I mentioned in #7. The problem was retranslation, again. I'm still trying to avoid the shadow DOM route. Here, I'm adding l10n-status="translated" to the node with l10n-id to know if it has already been translated at least once. This important for telling which nodes the localization should inherit attributres from.

The pull request depends on #7 because of how I wrote the testcase. It's actually just one commit more than #7: stasm/l20n@5c18bda400ef1f9489f4f29f365160a7693e38d1.

stasm commented 12 years ago

I'm working on a blog post about DOM overlays/fragments and I'd like to revisit this pull request. It's either l10n-status or shadow DOM tree. @zbraniecki, what are your thoughts on this?

zbraniecki commented 12 years ago

ehh, still don't like it, but failed to find any alternative in 5 months, so I'm merging it