zbrateam / Zebra

🦓 A Useful Package Manager for iOS
https://getzbra.com
GNU General Public License v3.0
1.18k stars 191 forks source link

Payment Providers with newlines don't work. #1953

Closed tale closed 2 years ago

tale commented 2 years ago

Describe the bug If the /payment_endpoint route on a repository returns an accidental newline at the end of the endpoint URL, then there will be scenarios where Payment Provider services don't work.

To Reproduce Create a dummy APT repository and set /payment_endpoint's return value to include a newline at the end.

Expected behavior Zebra should handle this by trimming newlines and whitespaces when parsing the endpoint. https://github.com/zbrateam/Zebra/blob/2539b4f86dc92d19af47240f2efdbd09056d9997/Zebra/Database/ZBDatabaseManager.m#L314