[Packages] Depiction scroll height bug fix (#1951)

zbrateam / Zebra

🦓 A Useful Package Manager for iOS

https://getzbra.com

GNU General Public License v3.0

1.18k stars 191 forks source link

[Packages] Depiction scroll height bug fix (#1951) #1980

Closed level3tjg closed 2 years ago

level3tjg commented 2 years ago

Setting the depiction's scroll view height to html.scrollHeight while both html and body tag heights are set to 100% will create a loop, causing the scroll view's height to infinitely grow.

Fixes #1951

kirb commented 2 years ago

Thanks! I only spotted this PR after causing some merge conflicts (oops), so rebased and merged manually in 98abd1e6.