zbrateam / Zebra

🦓 A Useful Package Manager for iOS
https://getzbra.com
GNU General Public License v3.0
1.18k stars 191 forks source link

Queue view controller doesn't display queued packages right away #1992

Closed L1ghtmann closed 1 year ago

L1ghtmann commented 2 years ago

Describe the bug If the queue view controller is not opened between queuing an initial package and subsequent packages, only the first package queued will be present in the view controller's view.

To Reproduce Add a package to the queue and don't open the queue view controller. Then add another package to the queue and open the queue view controller. Notice how the second of the two packages queued isn't displayed. This will be the case for all packages added after the initial one (assuming you don't open the queue before adding them).

Expected behavior The queue view controller's view to update as packages are added to the queue without having to open it once beforehand.

Screenshots [Bug] https://user-images.githubusercontent.com/67040127/173160333-7de01db1-77c9-4577-ace2-39369ca8bb92.mov

[Opening queue view controller after initial package is added exhibits normal behavior] https://user-images.githubusercontent.com/67040127/173160366-67f03fdc-140a-471d-9b07-93dcf9481a3d.mov

Device Information:

Crash Log or System Log N/A

Additional context Despite the view controller's view not updating properly, the queue tab bar does update correctly (see first screen recording).

The bug does not occur if the queue is opened after adding the initial package (see second screen recording above).

This issue was not present in 1.1.26 and appears to have begun in 1.1.27 and remains present in the latest stable release 1.1.28. I took a look at the commit history between 1.1.26 and 1.1.27 and nothing stood out. Would've dug a bit more, but I don't have a macOS install to be able to test things, unfortunately.

CySxL commented 2 years ago

I have the same issue. Usually launch the queue view controller once manually would fix it iirc. Device type : iPhone 11 Pro Max iOS version : 14.8 Jailbreak type : unc0ver 8.0.2 Zebra version : 1.1.28

elihwyma commented 1 year ago

Fixed in https://github.com/zbrateam/Zebra/commit/403b4ed9830f4da0b4ee09117c070f1182fb5b33