zbrateam / Zebra

🦓 A Useful Package Manager for iOS
https://getzbra.com
GNU General Public License v3.0
1.18k stars 191 forks source link

NSPhotoLibraryAddUsageDescription missing #2001

Closed CySxL closed 1 year ago

CySxL commented 1 year ago

Describe the bug Zebra crashes immediately after press "save to Photo" option in Force Touch menu on preview images.

To Reproduce <1.> Launch Zebra <2.> Find a tweak with preview images provided <3.> Force touch/3D touch the image <4.> Choose "save to Photo" option <5.> Zebra crashes

Expected behavior Successfully save images without app crash

Screenshots No screenshots.

Device Information:

Crash Log or System Log File : https://discord.com/channels/566255609251364864/566255609251364867/1037446032444883025 image

Additional context

kirb commented 1 year ago

Thanks for catching and reporting this! I did catch this myself once but forgot to make a note of it. Kinda silly that a WebKit feature requires the app to gain photo library permission 🙄

CySxL commented 1 year ago

Thanks for catching and reporting this! I did catch this myself once but forgot to make a note of it. Kinda silly that a WebKit feature requires the app to gain photo library permission 🙄

Hahaha 😂 No worries! It's my honor to help.

kirb commented 1 year ago

Fixed in 1.1.29. Thanks again for reporting!

CySxL commented 1 year ago

Fixed in 1.1.29. Thanks again for reporting!

Tested and I still have the crash after pressing "save to Photo" 😂

Crash logs :

image

kirb commented 1 year ago

Ahh… yep I thought I fixed it, but I just realised I actually forgot to add the file to the Xcode build 🤦‍♀️ I’ll get it actually fixed in the next release then.

CySxL commented 1 year ago

Ahh… yep I thought I fixed it, but I just realised I actually forgot to add the file to the Xcode build 🤦‍♀️ I’ll get it actually fixed in the next release then.

no worries 😂😂

iAdam1n commented 1 year ago

1.1.30 has been released and includes this fix.

CySxL commented 1 year ago

1.1.30 has been released and includes this fix.

confirmed fixed too ! Thanks for your hard work !