search

zbrateam / Zebra

🦓 A Useful Package Manager for iOS
https://getzbra.com
GNU General Public License v3.0
1.18k stars 191 forks source link

Cannot navigate to re-added repo #2028

Open CySxL opened 1 year ago

CySxL commented 1 year ago

Describe the bug Cannot navigate to re-added repo.

To Reproduce

  1. Add a repo that was not added before

  2. Wait for the refreshing tasks done

  3. Re-add the same repo again

  4. Zebra shows that you have added it before, do you want to check the repo ? Click "Yes, check"

  5. Zebra navigates you to a random existed repo instead of the just-re-added one

Expected behavior Navigate me to the re-added repo correctly.

Screenshots Video demo here: https://streamable.com/qzn298

As You can see, what I added is https://cydia.oatmealdome.me, but the navigation directs me to https://nickkgar.github.io/Nepeta-Mirror/

Device Information:

Crash Log or System Log No crash logs.

Additional context Zebra ask you if you want to check the added repo but it directs you to another random repo, for this case it's Nepeta's mirror repo instead of the DolphiniOS repo

kirb commented 1 year ago

Interesting bug, good catch! Thanks for reporting.

kirb commented 1 year ago

I wasn’t able to reproduce the bug, when I tapped the button it took me to the correct repo. I’m thinking it could be a bug due to the two repos you have at the top of the list with Chinese names. On your phone, 25mao is sorted under "6". On my phone, set to English, it’s under "L"! Do either of those seem correct? If not, the issue is very likely that it isn't sorting non-Latin letters correctly.

CySxL commented 1 year ago

I wasn’t able to reproduce the bug, when I tapped the button it took me to the correct repo. I’m thinking it could be a bug due to the two repos you have at the top of the list with Chinese names. On your phone, 25mao is sorted under "6". On my phone, set to English, it’s under "L"! Do either of those seem correct? If not, the issue is very likely that it isn't sorting non-Latin letters correctly.

Ah yeah! I haven't noticed that 😂😂 Good catch to you too! Haha.

And for that two repos, no, they are categorized wrongly. The title of Nepeta-Mirror repo is showing "未知" which means "Unknown" in English.

And the title of "25Mao" doesn't mean "6" in any ways. So yeah I think we got the issue here: Non-Latin letters glitching.

elihwyma commented 1 year ago

Even when adding those repo's I'm unable to reproduce this. Is it something that has been solved in future versions without anyone realising?