zbrateam / Zebra

🦓 A Useful Package Manager for iOS
https://getzbra.com
GNU General Public License v3.0
1.19k stars 193 forks source link

Update settings page to better support localizations #511

Closed worldlydev closed 5 years ago

worldlydev commented 5 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Lot's of localizations are too long and get cut off in the settings page. This isn't ideal and results in translators translating incorrectly to get shorter strings or leaving the translations as is.

Example of long strings in Zebra: 468A081B-FA1C-4317-B712-8ACDD0F102C1

Describe the solution you'd like A clear and concise description of what you want to happen.

I would like the the settings page to be slightly redesigned. The settings page is already using UITableView but I think it should be slighty adjusted so that it more closely mimics the actual settings app in iOS. Instead of using the UISegmentedControl as Zebra is now I think that each table should open up into a menu as settings does now. This leaves much more room allowing for better localization support but also makes the settings page easier to navigate and less cluttered.

Example from settings: 1C782E05-8DEE-41BF-A0AE-F47266677446

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

As I said in the beginning of this post the only options are leaving translations as is or incorrectly translating them to make the strings shorter.

Additional context Add any other context or screenshots about the feature request here.

I made a quick mockup of how a redesigned settings page could look: 0DD7D7B6-07B0-4E75-BB74-D18B5549BCC4

In my opinion this is the ideal version of an updated settings page in Zebra. Let me explain why:

I repaced the UISegmentedControls with tables that open up into menus. I moved the icon in the "change icon" tab to the right to make the settings page look more balanced as there is now text on the left and icons on the right. Last thing I did was add a short description in the menu, explaining what this setting actually changes.

worldlydev commented 5 years ago

I really hope this is considered for a future update. Maybe even 1.0 🤷‍♂️😉

relisiuol commented 5 years ago

Okay, lemme implement that.

ann0see commented 5 years ago

I saw the same problem here: https://imgur.com/a/TRtNnFV (Image is SFW)

worldlydev commented 5 years ago

I saw the same problem here: https://imgur.com/a/TRtNnFV (Image is SFW)

Can confirm that I have that issue as well. Just didn't get around to reporting it. It says kansel in the top right but should say kanseller.

78F8959D-9880-4D8E-9096-498D904BEF65

ann0see commented 5 years ago

And in the Packaging area the Header looks strange. https://imgur.com/a/U0K3RDI

wstyres commented 5 years ago

Implemented in #513