zbtang / React-Native-ViewPager

ViewPager and Indicator component for react-native on both android and ios.
950 stars 276 forks source link

ViewPagerAndroid has been removed from react native #200

Open rakefetWorkiz opened 3 years ago

rakefetWorkiz commented 3 years ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch rn-viewpager@1.2.9 for the project I'm working on.

The issue I had was : using this library will prompt an error saying ViewPagerAndroid has been removed from react native.

Here is the diff that solved my problem:

diff --git a/node_modules/rn-viewpager/viewpager/ViewPager.js b/node_modules/rn-viewpager/viewpager/ViewPager.js
index 41f8f1b..451701c 100644
--- a/node_modules/rn-viewpager/viewpager/ViewPager.js
+++ b/node_modules/rn-viewpager/viewpager/ViewPager.js
@@ -4,8 +4,9 @@

 'use strict'

-import { PanResponder, Platform, ScrollView, StyleSheet, View, ViewPagerAndroid } from 'react-native'
+import { PanResponder, Platform, ScrollView, StyleSheet, View } from 'react-native'
 import React, { Component } from 'react'
+import ViewPagerAndroid from '@react-native-community/viewpager'

 const SCROLLVIEW_REF = 'scrollView'
 const VIEWPAGER_REF = 'viewPager'

This issue body was partially generated by patch-package.

rakefetWorkiz commented 3 years ago

PS, I manually added to my dependencies @react-native-community/viewpager, I guess to fix the issue, you'll have to add the dependency to the library