search

zbx1425 / BlocklyAts

Create BVE ATS plugins with a beginner-friendly block-based programming tool. ブロックに基づいた簡単なツールで BVE ATS プラグインを作成。使用积木化的简单编程工具制作BVE ATS插件。
https://www.zbx1425.cn/nautilus/blocklyats
MIT License
20 stars 2 forks source link

beacon output is wrong. #1

Closed ntfiv closed 3 years ago

ntfiv commented 3 years ago

初めまして。興味深いソフトですので試用させていただきました。 beacon「type」で出力される情報がおかしくなっているようです。 「optional data」に設定すると「type」が出力されるようです。 ご確認をお願いします。

automatic translation Nice to meet you. This is an interesting software, so I tried it. It seems that the information output by beacon "type" is not correct. If you set it to "optional data", the "type" seems to be output. Please check it.

zbx1425 commented 3 years ago

It seems that I accidentally set the arguments in the wrong order. The software haven't been completely tested, sorry for the inconvenience! I'll fix it as soon as possible.

For temporary fix, change Line 119 of www/js/lua_generator_bve.js inside installation directory (https://github.com/zbx1425/BlocklyAts/blob/8fa58f869fca61b5b0278481de1afdad758662c6/www/js/lua_generator_bve.js#L119) from

  return "function __atsapi_setbeacondata(__atsarg_type, __atsarg_signal, __atsarg_distance, __atsarg_optional)\n";

to:

  return "function __atsapi_setbeacondata(__atsarg_distance, __atsarg_optional, __atsarg_signal, __atsarg_type)\n";
ntfiv commented 3 years ago

Thank you!　I was able to take first aid.

zbx1425 commented 3 years ago

New version 1.0.5.2 should fix #1 and #2. Please check it out when you have time to spare. If the issues are fixed, you can then close the issues. Thanks a lot!

ntfiv commented 3 years ago

Looks fine to me!　Thank you so much!