zbycz / osmapp

Lets make a universal app for OpenStreetMap
https://osmapp.org
GNU General Public License v3.0
219 stars 19 forks source link

Wikidata labels seem to get used instead of OpenStreetMap name-tags #221

Open jdhoek opened 11 months ago

jdhoek commented 11 months ago

If I look at the map I see the province of Namur in Belgium rendered as 'Provincie Namen'. There are two issues here:

In the OpenStreetMap data (relation 1311816) I am not seeing this 'Provincie Namen' name at all, but all name tags which could be relevant here (name, name:en, name:fr, name:nl) are set correctly. Why are these not used in preference to external data?

Wikidata (Q1125) does add 'province' in front of its labels. This is probably useful for Wikidata, but not for maps.

Any idea what's going on here?

zbycz commented 11 months ago

Hi, thanks for comment. There are two reasons for that:

1) osmapp uses Maptiler API, and they preprocess all the names and use the Wikidata/Wikipedia source as main, if something is missing it uses OSM data.

There is a pretty long discussion about integrating Maptiler Vector Tiles on main OSM website (as another layer) and i think they decied against in the end: https://github.com/openstreetmap/openstreetmap-website/pull/4042

I know it would be better to have a fully OSM-first tiles as well, but I don't have to capacity to run my own OpenMapTiles instance for the whole world. If you have the idea how to get funds/people for that, it would be also cool to run minutely updated OMT tiles from the Makina Maps stack https://github.com/zbycz/osmapp/issues/133.

2) Another reason is that Osmap currently uses English first labels, and it doesn't correctly change it according to the user - see here for more: https://docs.maptiler.com/sdk-js/examples/ip-map-language/

jdhoek commented 11 months ago

if something is missing it uses OSM data.

That… is pretty shocking. It basically takes the stance that OpenStreetMap data is incorrect, with Wikidata being better maintained. This is not my experience.

jdhoek commented 11 months ago

Is there a corresponding upstream MapTiler issue somewhere I can reference?

jdhoek commented 11 months ago

Ah, I see I opened one myself a while ago: https://github.com/openmaptiles/openmaptiles/issues/1547

zbycz commented 11 months ago

Yes, they made this decision in the beggining and now they probably can't undo, because their clients want it that way. I think some Maptiler representative spoke in the referenced issue.

ad PR) Wow, thats unexpected! Thanks for opening it. I hope we can see it resolved someday, or perhaps find another Vector tiles provider.. (i would esp. love to see minutely updated tiles!)

//edit: I added a disclaimer section to homepage which states this label issue.