zbycz / osmapp

Lets make a universal app for OpenStreetMap
https://osmapp.org
GNU General Public License v3.0
207 stars 17 forks source link

Add fitness_station and picnic_table POIs #56

Open kudlav opened 3 years ago

kudlav commented 3 years ago

Hi, I think it would be really usefull to display fitness_station and _picnic_table_.

But I did not find it in getPoiClass.ts or openmatiles poi.yam.

I found fitness_station in the following PR https://github.com/openmaptiles/openmaptiles/issues/15 but fitness_stations are still not included in OpenMapTiles demo.

zbycz commented 3 years ago

Hi,

the getPoiClass works like this: if it finds a leisure=fitness_station tag (see), it looks for the "fitness_station_11.svg" in /public/icons folder.

You can create a pull request with just the one (or two) icons.

zbycz commented 3 years ago

Can you link/screenshot the specific issue? I am not sure if I answered your question :)

kudlav commented 3 years ago

https://osmapp.org/49.208301,16.620516#18.96/49.2083/16.6206 there is this fitness_station: https://www.openstreetmap.org/way/389797459

So there is need to add different icon for fitness_station or every single tag that should be rendered? I think, https://osmapp.org/icons/fitness_centre_11.svg or pitch_11.svg is fine.

zbycz commented 3 years ago

I see. It is missing in the map, because the maptiler tiles are refreshed only once a month.

Though I want to setup my own OpenMapTiles instance, which would be refreshed minutely.

BTW, you can display any osm item on osmapp by just changing the URL like this:

https://osmapp.org/way/389797459

kudlav commented 3 years ago

Hi, this one was created three years ago, so this is not due to outdated maps.

https://www.openstreetmap.org/way/389797459/history

-- Vladan Kudláč

Dne st 28. 7. 2021 12:29 uživatel Pavel Zbytovský @.***> napsal:

I see. It is missing in the map, because the maptiler tiles are refreshed only once a month.

Though I want to setup my own OpenMapTiles instance, which would be refreshed minutely.

BTW, you can display any osm item on osmapp by just changing the URL like this:

https://osmapp.org/way/389797459

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zbycz/osmapp/issues/56#issuecomment-888200751, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACX3SY4Z5RMXLPQHY5SN6OLTZ7LZPANCNFSM5ASPQOHQ .

zbycz commented 3 years ago

I see, so in this case. The OpenMapTiles project doesnt process this kind of POI yet.

Please ask them at https://github.com/openmaptiles/openmaptiles/issues and be sure to mention this issue :-)