HamburgerMenu: Refactoring

zbycz / osmapp

Lets make a universal app for OpenStreetMap

https://osmapp.org

GNU General Public License v3.0

219 stars 19 forks source link

HamburgerMenu: Refactoring #767

Open jvaclavik opened 1 week ago

jvaclavik commented 1 week ago

unify hamburger menu with Profile (icon should be profile icon)
refactor icons without necessity of overriding components

zbycz commented 1 week ago

I would like to keep current state (two buttons) on desktop and only do the mentioned refactoring for MobileMode. Do you agree?

jvaclavik commented 1 day ago

I would like to keep current state (two buttons) on desktop and only do the mentioned refactoring for MobileMode. Do you agree?

I disagree, because I think it's counterintuitive to group it this way. We shouldn't teach our users on two buttons and then keep the same icon but add content from different section.