search

zcadditions / ZCA-Bootstrap-Template-for-1.5.6-v2.0.0c

Zen Cart v1.5.6a, ZCAdditions (rbarbour), Bootstrap 4 Template
http://www.zcadditions.com/bootstrap_tpl_demo
GNU General Public License v3.0
14 stars 19 forks source link

ZCA Bootstrap Colors does not affect some cards in the center column #153

Open chindraba-work opened 5 years ago

chindraba-work commented 5 years ago

Many of the cards displayed in the center column have a white background for the card, and sometimes for the content of the card as well. New products and featured products have a white card while the items are controlled by the color choices. The product list and sub categories cards are completely white. In the product information page, the price card and information cards are solid white while the product description area is controlled by the settings.

When creating a dark theme, it's rather disconcerting to have all the extra white showing up, and with the light, or white, text in a dark theme it is difficult, or impossible, to read the information printed over a white background.

In some cases, attributes and add to cart cards for example, even the header is not controlled by the settings.

center_cards_not_affected-ezpage_list center_cards_not_affected-product_info center_cards_not_affected-shipping center_cards_not_affected-sub_cats

In the special case of the order total (both in the cart and the order history) the contents of the table for forced to a white background with a class of bg-white, and even manually forcing the background on the card to some color is cancelled within the table. Aside from the "break" in the theme, it also makes the information within the table potentially invisible to the customer.

order_total_table_forced_white-forced_background order_total_table_forced_white-generated_background

zcadditions commented 5 years ago

Further color option need to be added to ZCA Bootstrap Colors to change card background colors and text colors.

  1. Add options for individual cards (allot).
  2. Add option for all (universal) cards.
  3. Keep this as is and update readme to change via CSS
chindraba-work commented 5 years ago

My thoughts, after experimenting some with this, is to take the universal route. Make the settings for the "center" apply to all cards which display in the center. Add a few more items to cover all of the center's elements not yet covered, if needed. I think it's mostly lists and list items that are missing controls.

Then modify the readme with instructions on how to modify the includes/templates/bootstrap/css/stylesheet_zca_colors.php file to control individual elements if desired.

I think it's likely rare that someone would want to style the different cards in different ways. Rather, I suspect that they want the center boxes to present a common theme throughout. Also possible is that the users want the centerbox cards and the sidebox cards to be themed the same, and the centerbox specific settings could be removed and their styling merged with the sidebox controls, relying on the CSS instructions for users who do prefer a separation between the styling.

It might be handy to include in the instructions all the element class names broken down by their use to help those who wish extreme control of the cards. Of course, using "inspect Element" in Firefox, or "Inspect" in Chrome, will give the same information with all the context information they could need.