zcadditions / ZCA-Bootstrap-Template-for-1.5.6-v2.0.0c

Zen Cart v1.5.6a, ZCAdditions (rbarbour), Bootstrap 4 Template
http://www.zcadditions.com/bootstrap_tpl_demo
GNU General Public License v3.0
14 stars 19 forks source link

styling/layout improvements for v300 #303

Closed drbyte closed 3 years ago

drbyte commented 3 years ago

Banners

Category Description (see first image)

Product Listing issues (see 2nd image) (affects index/cats/prod-new-all-featured-specials)

Sideboxes (5th image)

@barco57 do you have some insights on best approaches for some of these?


1

category-description

2

product-listing-pagination-etc

3

padding-for-prices

4

padding-above-centerboxes

5

category-separator
lat9 commented 3 years ago

Re: Category Description. The image is present in '#indexProductList-categoryImage' and the description in '#indexProductList-content'. Do those need additional styling?

I could add a <div class="p-2"></div> if the category description is present.

lat9 commented 3 years ago

For image 4, there's a setting that I'm not finding that displays the listing even if there's only one product. Where the heck is that?

drbyte commented 3 years ago

For image 4, there's a setting that I'm not finding that displays the listing even if there's only one product. Where the heck is that?

I believe you mean Admin->Configuration->Layout Settings->Skip 1-prod Categories (I would argue that it makes more sense under Product Listing, but that's outside the scope of this template.)

drbyte commented 3 years ago

Re: Category Description. The image is present in '#indexProductList-categoryImage' and the description in '#indexProductList-content'. Do those need additional styling?

I'm undecided. @barco57 ?

I could add a <div class="p-2"></div> if the category description is present.

It would be nice if it could be done without having two conditional checks, eg one for opening div and one for closing div. But that may not be an option if the title/image need to be inside the div.

I'm slightly more inclined to merely (or at the very least) add an unstyled div around it, so that if someone wanted to add a border or apply a background color, etc, at least they can target that specific segment directly via css without having to find the right template file to edit.

lat9 commented 3 years ago

That change just pushed corrects the display for image-4 (product listing, no space). Essentially, modifying the zca_split_pages_result class to return &nbsp; when there's only one product.

lat9 commented 3 years ago

Products listing, removing "Product Image" heading. For rows, use the associated text-{whatever} class (was causing a non-HTML5 align= attribute to be added). Additional elements added to the stylesheet for padding and to add a margin above the bottom navigation.

lat9 commented 3 years ago

That commit corrects the layout for the split-page-results (also some refactoring for readability).

lat9 commented 3 years ago

The category-related elements on a product-listing is now wrapped via #indexProductList-cat-wrap, enabling that/those elements to be containerized.

lat9 commented 3 years ago

Added a margin below that newly-added element.

lat9 commented 3 years ago

For item 1 (banner centering), each of the 'main-section' banners (1, 3, 4 and 6) now have a zca-banner class and are, by default (via the stylesheet) centered. Site-specific styling can target a specific banner group, e.g. .bannerSix to override the alignment.

lat9 commented 3 years ago

... and there's the final one, correcting categories sidebox display when a category with sub-categories is the currently-selected category.