search

zcash / librustzcash

Rust-language assets for Zcash
Other
333 stars 249 forks source link

Disable `sapling-crypto` default features by default #1399

Closed str4d closed 4 months ago

str4d commented 4 months ago

The only default-enabled feature flag in sapling-crypto is the multicore feature flag, which we re-export in each crate that includes proof creation. We need to disable it as a default feature of our dependency in order to enable it to be correctly disabled when a user of e.g. zcash_primitives disables its default features.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.13%. Comparing base (0b350c1) to head (f136535).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1399 +/- ## ======================================= Coverage 63.13% 63.13% ======================================= Files 126 126 Lines 14720 14720 ======================================= Hits 9293 9293 Misses 5427 5427 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

str4d commented 4 months ago

The cargo vet issue I'm not going to resolve in this PR, as I expect it would cause conflicts with #1392. (It's just that the "new" zcash_primitives version isn't visible to the audit config file.)

str4d commented 4 months ago

8b2188a0f34fea2cebbf48a9945c75715f92992e published as zcash_primitives-0.15.1.