zcash / librustzcash

Rust-language assets for Zcash
Other
324 stars 242 forks source link

Improvements to the strategy implemented by `{fixed,standard,zip317}::SingleOutputChangeStrategy` #1430

Closed daira closed 1 week ago

daira commented 1 week ago

zcash_client_backend::{fixed,standard,zip317}::SingleOutputChangeStrategy now implement a different strategy for choosing whether there will be any change, and its value. The aims are:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 63.16%. Comparing base (06c0895) to head (7710919).

:exclamation: Current head 7710919 differs from pull request most recent head 21d5731

Please upload reports for the commit 21d5731 to get more accurate results.

Files Patch % Lines
zcash_client_backend/src/fees/common.rs 75.00% 21 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1430 +/- ## ========================================== + Coverage 63.08% 63.16% +0.08% ========================================== Files 127 127 Lines 14821 14868 +47 ========================================== + Hits 9350 9392 +42 - Misses 5471 5476 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.