search

zcash / librustzcash

Rust-language assets for Zcash
Other
333 stars 249 forks source link

zcash_client_sqlite: Fix handling of PRAGMA directives. #1433

Closed nuttycom closed 3 months ago

nuttycom commented 3 months ago

The foreign_keys pragma has no effect when used within a transaction, so it should only be set at the top level. The legacy_alter_table pragma should only be used in cases where its effect is explicitly intended.

Best reviewed hiding whitespace changes.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.13%. Comparing base (4b2a942) to head (1110f5d). Report is 2 commits behind head on main.

Files Patch % Lines
...ite/src/wallet/init/migrations/full_account_ids.rs 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1433 +/- ## ========================================== - Coverage 63.16% 63.13% -0.03% ========================================== Files 127 127 Lines 14868 14864 -4 ========================================== - Hits 9391 9385 -6 - Misses 5477 5479 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.