search

zcash / librustzcash

Rust-language assets for Zcash
Other
324 stars 242 forks source link

Ensure symmetry of transparent output handling between `put_blocks`, `store_decrypted_tx` and `store_sent_tx` #1434

Open nuttycom opened 1 week ago

nuttycom commented 1 week ago

AFAICT (at least as of the first commit in the PR), this NULL AS from_account_id is preserved, because there is still an asymmetry between transparent and shielded (we are not inserting transactions into both sent and received tables for transparent, in the same way we do for shielded). I think that asymmetry needs fixing prior to the next release (if not in this PR).

_Originally posted by @str4d in https://github.com/zcash/librustzcash/pull/1402#discussion_r1648028219_

_See also https://github.com/zcash/librustzcash/pull/1402#discussion_r1648037109_

daira commented 3 days ago

Did merging #1402 fix this, or is there more to do?