Update signature hashes to inhibit "Possible large transaction fee via two Segwit transactions"

zcash / librustzcash

Rust-language assets for Zcash

Other

336 stars 252 forks source link

Update signature hashes to inhibit "Possible large transaction fee via two Segwit transactions" #298

Open nuttycom opened 4 years ago

nuttycom commented 4 years ago

Noted here:

Amounts were added to sighash following the SegWit design, but per this SegWit bug it was insufficient to protect hardware wallets from incorrectly computing fees. Given that we need everyone to migrate to a new sighash for TZE-containing transactions, we should a) fix this for TZE inputs, and b) simultaneously fix this for transparent inputs in TZE-supporting transactions.

nuttycom commented 2 weeks ago

Verify that this was fixed in ZIP 244 (https://zips.z.cash/zip-0244#rationale)