zcash / librustzcash

Rust-language assets for Zcash
Other
339 stars 252 forks source link

Use SHAs to pin GitHub Actions versions #774

Open ccjernigan opened 1 year ago

ccjernigan commented 1 year ago

Rather than using tagged versions for GitHub Actions, our builds could be more reproducible if we leveraged the Git shas instead.

https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

str4d commented 1 year ago

We use Dependabot to ensure our actions workflows are up-to-date. @ccjernigan pointed me to an example of Dependabot understanding revision-pinned dependencies and updating them to tag-matched revisions: https://github.com/zcash/kotlin-bip39/pull/151

It would be nicer if Dependabot added a comment indicating which version the revision corresponds to, but otherwise that looks very nice (and I'm now curious as to why Dependabot isn't just upgrading everyone's workflows to revisions if it is configured to provide updates).

In any case, after #773 merges the only actions we will depend on that are not authored by GitHub itself are: