zcash / orchard

Implementation of the Zcash Orchard Protocol
https://zcash.github.io/orchard/
Other
53 stars 37 forks source link

Dummy implementation of Domain API change for prepared ivk and epk #357

Closed daira closed 2 years ago

daira commented 2 years ago

This adapts to API changes in https://github.com/zcash/librustzcash/pull/633 without changing the behaviour for Orchard.

codecov-commenter commented 2 years ago

Codecov Report

Base: 88.90% // Head: 88.84% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (f56b50a) compared to base (3faab98). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #357 +/- ## ========================================== - Coverage 88.90% 88.84% -0.06% ========================================== Files 37 38 +1 Lines 3858 3865 +7 ========================================== + Hits 3430 3434 +4 - Misses 428 431 +3 ``` | [Impacted Files](https://codecov.io/gh/zcash/orchard/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash) | Coverage Δ | | |---|---|---| | [src/note\_encryption.rs](https://codecov.io/gh/zcash/orchard/pull/357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL25vdGVfZW5jcnlwdGlvbi5ycw==) | `89.03% <100.00%> (+0.29%)` | :arrow_up: | | [src/lib.rs](https://codecov.io/gh/zcash/orchard/pull/357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2xpYi5ycw==) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

str4d commented 2 years ago

Force-pushed to address @daira's comment.

daira commented 2 years ago

utACK