codecov-commenter
commented
1 year ago Codecov Report
Base: 84.13% // Head: 83.86% // Decreases project coverage by -0.26% :warning:
Coverage data is based on head (
b3e196e) compared to base (d05b6ce). Patch coverage: 0.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #365 +/- ## ========================================== - Coverage 84.13% 83.86% -0.27% ========================================== Files 32 32 Lines 2672 2678 +6 ========================================== - Hits 2248 2246 -2 - Misses 424 432 +8 ``` | [Impacted Files](https://codecov.io/gh/zcash/orchard/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash) | Coverage Δ | | |---|---|---| | [src/builder.rs](https://codecov.io/gh/zcash/orchard/pull/365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2J1aWxkZXIucnM=) | `65.93% <0.00%> (-2.39%)` | :arrow_down: | | [src/note.rs](https://codecov.io/gh/zcash/orchard/pull/365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL25vdGUucnM=) | `88.57% <0.00%> (-0.17%)` | :arrow_down: | | [src/circuit.rs](https://codecov.io/gh/zcash/orchard/pull/365/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2NpcmN1aXQucnM=) | `92.51% <0.00%> (-0.03%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The
Input/OutputViewtraits are nearly straight-copied from https://github.com/zcash/librustzcash/blob/main/zcash_primitives/src/transaction/components/sapling/fees.rs, I'm assuming that interface is the desired one to this kind of functionality.