zcash / orchard

Implementation of the Zcash Orchard Protocol
https://zcash.github.io/orchard/
Other
54 stars 39 forks source link

Add concrete error types for add_spend and add_output #366

Closed AloeareV closed 1 year ago

AloeareV commented 1 year ago

orchard::builder::Error is now BuildError to disambiguate from SpendError, if breaking changes are an issue that could be type-aliased to Error.

codecov-commenter commented 1 year ago

Codecov Report

Base: 84.13% // Head: 84.15% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (9807e32) compared to base (d05b6ce). Patch coverage: 35.71% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #366 +/- ## ========================================== + Coverage 84.13% 84.15% +0.02% ========================================== Files 32 32 Lines 2672 2670 -2 ========================================== - Hits 2248 2247 -1 + Misses 424 423 -1 ``` | [Impacted Files](https://codecov.io/gh/zcash/orchard/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash) | Coverage Δ | | |---|---|---| | [src/builder.rs](https://codecov.io/gh/zcash/orchard/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2J1aWxkZXIucnM=) | `68.77% <35.71%> (+0.45%)` | :arrow_up: | | [src/note.rs](https://codecov.io/gh/zcash/orchard/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL25vdGUucnM=) | `88.57% <0.00%> (-0.17%)` | :arrow_down: | | [src/circuit.rs](https://codecov.io/gh/zcash/orchard/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash#diff-c3JjL2NpcmN1aXQucnM=) | `92.51% <0.00%> (-0.03%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zcash)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.