search

zcash / orchard

Implementation of the Zcash Orchard Protocol
https://zcash.github.io/orchard/
Other
53 stars 37 forks source link

Add a `Rho` type, to distinguish from revealed nullifiers of spent notes. #421

Closed nuttycom closed 6 months ago

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 45.83333% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 79.98%. Comparing base (a6b3407) to head (b2efb4c).

Files Patch % Lines
src/note_encryption.rs 4.00% 24 Missing :warning:
src/circuit.rs 50.00% 1 Missing :warning:
src/note.rs 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #421 +/- ## ========================================== - Coverage 80.49% 79.98% -0.52% ========================================== Files 30 30 Lines 3158 3192 +34 ========================================== + Hits 2542 2553 +11 - Misses 616 639 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nuttycom commented 6 months ago

force-pushed to rebase to main and address comments from code review.

nuttycom commented 6 months ago

This should probably be re-reviewed in its entirety at this point; by making it possible to create fake CompactAction values directly, I've (afaict) removed all the need to be able to independently evaluate the function Nullifier -> Rho.