arthurgreef commented 2 years ago

Hi there. Any change of a review soon? Thanks.

arthurgreef commented 2 years ago

Hi - can someone take a look? Thanks.

codecov-commenter commented 2 years ago

Codecov Report

Merging #43 (37dedf2) into main (682a0e6) will increase coverage by 4.45%. The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   66.15%   70.60%   +4.45%     
==========================================
  Files          12       12              
  Lines        1427     1456      +29     
==========================================
+ Hits          944     1028      +84     
+ Misses        483      428      -55

Impacted Files	Coverage Δ
src/curves.rs	`52.04% <72.22%> (+13.27%)`	:arrow_up:
src/lib.rs	`100.00% <100.00%> (ø)`
src/vesta.rs	`74.07% <0.00%> (-25.93%)`	:arrow_down:
src/pallas.rs	`84.48% <0.00%> (-15.52%)`	:arrow_down:
src/fields/fq.rs	`84.00% <0.00%> (+4.28%)`	:arrow_up:
src/fields/fp.rs	`84.57% <0.00%> (+4.28%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 682a0e6...37dedf2. Read the comment docs.

arthurgreef commented 2 years ago

Thanks for the review @daira. I was not sure if my change is what you were looking for. Bincode is a dev dependency so that implementors can choose how they would like to serde. I added bincode options to the test.

arthurgreef commented 2 years ago

Hey @daira, any chance you could take another look? Thanks.

daira commented 2 years ago

This and #48 appear to conflict.

arthurgreef commented 2 years ago

Hi @daira , This PR can be rejected when/if #48 is accepted. Thanks.

str4d commented 1 year ago

Closing in favour of #48.

zcash / pasta_curves

Serde for Affine points #43

Codecov Report