Closed vmx closed 1 year ago
Base: 66.15% // Head: 72.35% // Increases project coverage by +6.20%
:tada:
Coverage data is based on head (
d9b9fe1
) compared to base (682a0e6
). Patch coverage: 95.18% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@vmx Would you also consider adding borsh support or is that out of scope?
@parazyd I won't have time working on borsh support.
@vmx Alright, I will then add it after this PR is merged. Thank you.
Is this going to be merged in?
This PR needs to be rebased (GitHub's UI indicates there is a merge conflict).
As I needed to rebase, I did merged all commits into a single one. It should now include all the things mentioned in the review.
Notable things are:
bincode
to test the non human readable version.serde
as feature name. The "hack" renaming the crate was inspired https://github.com/RustCrypto/RSA/pull/41/files. Once the minimum required Rust version is 1.60, the dep:serde
can be used in the feature flag definitionsFollowing this model, I have also implemented Serde for the Ep
and Eq
types. Should I open a separate PR or wait till this one is merged?
Currently Serde is only implemented for
Fp
,Fq
,EpAffine
andEqAffine
. Support can be enabled with theserde
feature.It's based on the implementation in
blstrs
: https://github.com/filecoin-project/blstrs/blob/master/src/serde_impl.rsPlease let me know if that's the correct approach, or e.g. you'd like to serialize them to four
u64
s.I've only implemented it for the things I currently need, but I'm happy to provide an implementation for all curves.